Overall, looks good. Thanks for the patch Fred. Minor refactoring
suggestions below.

Instead of making checkContentType and checkCharacterEncoding public and
deprecated, would it be better to add another option of
expectedContentType to readContentAsUtf8, and just do everything there?
(the readContentAsUtf8 method already calls checkContentType and
checkCharacterEncoding) This might also enable inling of
RequestFactoryServlet.getContentAsUtf8. Finally, here is a  sorting
error in RPCServletUtils; so please do run 'ant checkstyle' before
uploading the next patch.



http://gwt-code-reviews.appspot.com/674804/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to