http://gwt-code-reviews.appspot.com/674804/diff/9001/10002 File user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java (right):
http://gwt-code-reviews.appspot.com/674804/diff/9001/10002#newcode96 user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java:96: // TODO: do something better here... On 2010/08/03 01:09:13, amitmanjhi wrote:
This will probably not work. The client code cannot depend on the
server code.
Define the constant in RequestFactory?
Done. http://gwt-code-reviews.appspot.com/674804/diff/9001/10005 File user/src/com/google/gwt/user/server/rpc/RPCServletUtils.java (right): http://gwt-code-reviews.appspot.com/674804/diff/9001/10005#newcode377 user/src/com/google/gwt/user/server/rpc/RPCServletUtils.java:377: if (contentType.startsWith(expectedContentType)) { On 2010/08/03 01:09:13, amitmanjhi wrote:
.toLowerCase() missing?
Thank you! Done. http://gwt-code-reviews.appspot.com/674804/diff/9001/10006 File user/test/com/google/gwt/user/server/rpc/RPCServletUtilsTest.java (right): http://gwt-code-reviews.appspot.com/674804/diff/9001/10006#newcode293 user/test/com/google/gwt/user/server/rpc/RPCServletUtilsTest.java:293: return RPCServletUtils.readContentAsGwtRpc(m); On 2010/08/03 01:09:13, amitmanjhi wrote:
Double-check? Translation seems different from line 181.
Done. http://gwt-code-reviews.appspot.com/674804/diff/17001/18006#newcode250 user/test/com/google/gwt/user/server/rpc/RPCServletUtilsTest.java:250: public void testReadNullCharacterEncoding() throws IOException { Adding a case sensitivity test since we had been only testing lowercase charsets. http://gwt-code-reviews.appspot.com/674804/diff/17001/18006#newcode301 user/test/com/google/gwt/user/server/rpc/RPCServletUtilsTest.java:301: Using 'null' here for clarity, since the content type is never used. http://gwt-code-reviews.appspot.com/674804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
