LGTM++
http://gwt-code-reviews.appspot.com/775802/diff/1/3 File user/src/com/google/gwt/cell/client/CheckboxCell.java (right): http://gwt-code-reviews.appspot.com/775802/diff/1/3#newcode37 user/src/com/google/gwt/cell/client/CheckboxCell.java:37: "<input type=\"checkbox\" checked />"; Can the space before the close bracket be eliminated? Same comment for INPUT_UNCHECKED. http://gwt-code-reviews.appspot.com/775802/diff/1/4 File user/src/com/google/gwt/cell/client/TextInputCell.java (right): http://gwt-code-reviews.appspot.com/775802/diff/1/4#newcode69 user/src/com/google/gwt/cell/client/TextInputCell.java:69: } You can save some work by rewriting lines 62-68 something like this: String s = viewData != null ? viewData : (value != null ? value : null); if (s != null) { sb.append("<input type='text' value=").append(s).append("'></input>"); } else { sb.append("<input type='text'></input>"); } http://gwt-code-reviews.appspot.com/775802/diff/1/5 File user/src/com/google/gwt/user/cellview/client/CellTable.java (right): http://gwt-code-reviews.appspot.com/775802/diff/1/5#newcode699 user/src/com/google/gwt/user/cellview/client/CellTable.java:699: sb.append(i % 2 == 0 ? evenRowStyle : oddRowStyle); The compiler may already catch this but if not you can rewrite i %2 as i & 0x1. http://gwt-code-reviews.appspot.com/775802/diff/1/5#newcode701 user/src/com/google/gwt/user/cellview/client/CellTable.java:701: sb.append(" ").append(selectedRowStyle); You could define selectedRowStyle as " " + style.selectedRow() in line 690 and avoid the extra append here http://gwt-code-reviews.appspot.com/775802/diff/1/5#newcode708 user/src/com/google/gwt/user/cellview/client/CellTable.java:708: sb.append(" ").append(firstColumnStyle); Same trick as for selectedRowStyle above http://gwt-code-reviews.appspot.com/775802/diff/1/5#newcode712 user/src/com/google/gwt/user/cellview/client/CellTable.java:712: sb.append(" ").append(lastColumnStyle); Same trick as for selectedRowStyle above http://gwt-code-reviews.appspot.com/775802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
