http://gwt-code-reviews.appspot.com/775802/diff/1/3
File user/src/com/google/gwt/cell/client/CheckboxCell.java (right):
http://gwt-code-reviews.appspot.com/775802/diff/1/3#newcode37
user/src/com/google/gwt/cell/client/CheckboxCell.java:37: "<input
type=\"checkbox\" checked />";
Done.
Good catch. It actually fails CheckboxCellTest to have it there.
http://gwt-code-reviews.appspot.com/775802/diff/1/4
File user/src/com/google/gwt/cell/client/TextInputCell.java (right):
http://gwt-code-reviews.appspot.com/775802/diff/1/4#newcode69
user/src/com/google/gwt/cell/client/TextInputCell.java:69: }
On 2010/08/18 01:13:29, Dan Rice wrote:
You can save some work by rewriting lines 62-68 something like this:
String s = viewData != null ? viewData : (value != null ? value :
null);
if (s != null) {
sb.append("<input type='text'
value=").append(s).append("'></input>");
} else {
sb.append("<input type='text'></input>");
}
Done.
http://gwt-code-reviews.appspot.com/775802/diff/1/5
File user/src/com/google/gwt/user/cellview/client/CellTable.java
(right):
http://gwt-code-reviews.appspot.com/775802/diff/1/5#newcode699
user/src/com/google/gwt/user/cellview/client/CellTable.java:699:
sb.append(i % 2 == 0 ? evenRowStyle : oddRowStyle);
I think thats less clear, and I don't think it will make much difference
in performance.
http://gwt-code-reviews.appspot.com/775802/diff/1/5#newcode701
user/src/com/google/gwt/user/cellview/client/CellTable.java:701:
sb.append(" ").append(selectedRowStyle);
On 2010/08/18 01:13:29, Dan Rice wrote:
You could define selectedRowStyle as " " + style.selectedRow() in line
690 and
avoid the extra append here
Done.
http://gwt-code-reviews.appspot.com/775802/diff/1/5#newcode708
user/src/com/google/gwt/user/cellview/client/CellTable.java:708:
sb.append(" ").append(firstColumnStyle);
On 2010/08/18 01:13:29, Dan Rice wrote:
Same trick as for selectedRowStyle above
Done.
http://gwt-code-reviews.appspot.com/775802/diff/1/5#newcode712
user/src/com/google/gwt/user/cellview/client/CellTable.java:712:
sb.append(" ").append(lastColumnStyle);
On 2010/08/18 01:13:29, Dan Rice wrote:
Same trick as for selectedRowStyle above
Done.
http://gwt-code-reviews.appspot.com/775802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
