LGTM + nits
http://gwt-code-reviews.appspot.com/776801/diff/1/3 File dev/core/src/com/google/gwt/dev/Permutation.java (right): http://gwt-code-reviews.appspot.com/776801/diff/1/3#newcode112 dev/core/src/com/google/gwt/dev/Permutation.java:112: for (StaticPropertyOracle oracle : orderedPropertyOracles) { indentation is off here. http://gwt-code-reviews.appspot.com/776801/diff/1/6 File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java (right): http://gwt-code-reviews.appspot.com/776801/diff/1/6#newcode240 dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java:240: System.out.println("Properties: " + permutation.prettyPrint()); I think one of these calls to prettyPrint is a dup. http://gwt-code-reviews.appspot.com/776801/diff/1/8 File dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java (right): http://gwt-code-reviews.appspot.com/776801/diff/1/8#newcode142 dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:142: double durationMs = convertToMilliseconds(durationNanos); duration should just be set to 0 here. http://gwt-code-reviews.appspot.com/776801/diff/1/8#newcode469 dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:469: + "(You must install the SpeedTracer extension to open this file)</span></p>" perhaps we should add a link to the APU download page as well: https://chrome.google.com/extensions/detail/ognampngfcbddbfemdapefohjiobgbdl http://gwt-code-reviews.appspot.com/776801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
