http://gwt-code-reviews.appspot.com/776801/diff/1/3 File dev/core/src/com/google/gwt/dev/Permutation.java (right):
http://gwt-code-reviews.appspot.com/776801/diff/1/3#newcode112 dev/core/src/com/google/gwt/dev/Permutation.java:112: for (StaticPropertyOracle oracle : orderedPropertyOracles) { On 2010/08/18 15:24:56, conroy wrote:
indentation is off here.
Done. http://gwt-code-reviews.appspot.com/776801/diff/1/6 File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java (right): http://gwt-code-reviews.appspot.com/776801/diff/1/6#newcode240 dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java:240: System.out.println("Properties: " + permutation.prettyPrint()); On 2010/08/18 15:24:56, conroy wrote:
I think one of these calls to prettyPrint is a dup.
One of them comes out in the SpeedTracer log, the other one comes out if you turn on tracing. http://gwt-code-reviews.appspot.com/776801/diff/1/8 File dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java (right): http://gwt-code-reviews.appspot.com/776801/diff/1/8#newcode142 dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:142: double durationMs = convertToMilliseconds(durationNanos); On 2010/08/18 15:24:56, conroy wrote:
duration should just be set to 0 here.
Done. http://gwt-code-reviews.appspot.com/776801/diff/1/8#newcode469 dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:469: + "(You must install the SpeedTracer extension to open this file)</span></p>" On 2010/08/18 15:24:56, conroy wrote:
perhaps we should add a link to the APU download page as well:
https://chrome.google.com/extensions/detail/ognampngfcbddbfemdapefohjiobgbdl There is already a link right above it to the main SpeedTracer page which has installation instructions - do you think that's enough? http://gwt-code-reviews.appspot.com/776801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
