Reviewers: cromwellian,

Description:
Ignoring __gwt_ObjectId in AbstractRequest#processRelated.  The
__gwt_ObjectId attribute is added by Chrome dev mode to all objects
passed between JSNI and Java.


Please review this at http://gwt-code-reviews.appspot.com/760803/show

Affected files:
  M user/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java


Index: user/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java
===================================================================
--- user/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java (revision 8599) +++ user/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java (working copy)
@@ -79,10 +79,10 @@
   /**
    * @deprecated use {...@link #with(String...)} instead.
    * @param properties
-   * @return
    */
+  @Deprecated
   public R forProperties(Collection<Property<?>> properties) {
-    for (Property p : properties) {
+    for (Property<?> p : properties) {
       with(p.getName());
     }
     return getThis();
@@ -135,6 +135,8 @@
   protected native void processRelated(JavaScriptObject related) /*-{
     for(var recordKey in related) {
       var schemaAndId = recordKey.split(/-/, 2);
+      // Workaround for __gwt_ObjectId appearing in Chrome dev mode.
+      if (schemaAndId == '__gwt_ObjectId') continue;
       var jso = related[recordKey];
[email protected]::setSchemaAndRecord(Ljava/lang/String;Lcom/google/gwt/requestfactory/client/impl/RecordJsoImpl;)(schemaAndId[0], jso);
     }


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to