http://gwt-code-reviews.appspot.com/847801/diff/1/2 File tools/api-checker/config/gwt20_21userApi.conf (right):
http://gwt-code-reviews.appspot.com/847801/diff/1/2#newcode115 tools/api-checker/config/gwt20_21userApi.conf:115: # there needs to be: method(SafeHtml html), etc. On 2010/09/07 20:22:33, jat wrote:
Should probably add a statement that null is not acceptable to any of
these
methods, so adding the overload is unlikely to break any code besides
possibly
test mocks.
Done. http://gwt-code-reviews.appspot.com/847801/diff/1/4 File user/src/com/google/gwt/user/client/ui/Anchor.java (right): http://gwt-code-reviews.appspot.com/847801/diff/1/4#newcode166 user/src/com/google/gwt/user/client/ui/Anchor.java:166: On 2010/09/07 20:22:33, jat wrote:
Spaces.
Done. http://gwt-code-reviews.appspot.com/847801/diff/1/5 File user/src/com/google/gwt/user/client/ui/Button.java (right): http://gwt-code-reviews.appspot.com/847801/diff/1/5#newcode92 user/src/com/google/gwt/user/client/ui/Button.java:92: On 2010/09/07 20:22:33, jat wrote:
Spaces.
Done. http://gwt-code-reviews.appspot.com/847801/diff/1/9 File user/src/com/google/gwt/user/client/ui/CustomButton.java (right): http://gwt-code-reviews.appspot.com/847801/diff/1/9#newcode449 user/src/com/google/gwt/user/client/ui/CustomButton.java:449: On 2010/09/07 20:22:33, jat wrote:
Spaces.
Done. http://gwt-code-reviews.appspot.com/847801/diff/1/24 File user/src/com/google/gwt/user/client/ui/StackLayoutPanel.java (right): http://gwt-code-reviews.appspot.com/847801/diff/1/24#newcode436 user/src/com/google/gwt/user/client/ui/StackLayoutPanel.java:436: public void setHeaderSafeHtml(int index, SafeHtml html) { On 2010/09/07 20:22:33, jat wrote:
Why not just setHeaderHtml(int, SafeHtml)? It is still just setting
the HTML,
and the others all just overloaded the same method.
Good point. Done. http://gwt-code-reviews.appspot.com/847801/diff/1/27 File user/src/com/google/gwt/user/client/ui/TabBar.java (right): http://gwt-code-reviews.appspot.com/847801/diff/1/27#newcode544 user/src/com/google/gwt/user/client/ui/TabBar.java:544: public void setTabSafeHtml(int index, SafeHtml html) { On 2010/09/07 20:22:33, jat wrote:
Here also -- why not just overload setTabHTML?
Done. http://gwt-code-reviews.appspot.com/847801/diff/1/28 File user/src/com/google/gwt/user/client/ui/TabLayoutPanel.java (right): http://gwt-code-reviews.appspot.com/847801/diff/1/28#newcode482 user/src/com/google/gwt/user/client/ui/TabLayoutPanel.java:482: public void setTabSafeHtml(int index, SafeHtml html) { On 2010/09/07 20:22:33, jat wrote:
And here.
Done. http://gwt-code-reviews.appspot.com/847801/diff/1/29 File user/src/com/google/gwt/user/client/ui/TreeItem.java (right): http://gwt-code-reviews.appspot.com/847801/diff/1/29#newcode613 user/src/com/google/gwt/user/client/ui/TreeItem.java:613: public void setSafeHtml(SafeHtml html) { On 2010/09/07 20:22:33, jat wrote:
And here.
In this case, setSafeHtml() is the method defined in the interface HasSafeHtml. I am changing this to setHTML(SafeHtml), and the interface as well. http://gwt-code-reviews.appspot.com/847801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
