LGTM!

http://gwt-code-reviews.appspot.com/847801/diff/8002/13005
File user/src/com/google/gwt/user/client/ui/Anchor.java (right):

http://gwt-code-reviews.appspot.com/847801/diff/8002/13005#newcode117
user/src/com/google/gwt/user/client/ui/Anchor.java:117:
this(html.asString(), true);
This is dropping the href?
this(html.asString(), true, href);

http://gwt-code-reviews.appspot.com/847801/diff/8002/13026
File user/src/com/google/gwt/user/client/ui/StackLayoutPanel.java
(right):

http://gwt-code-reviews.appspot.com/847801/diff/8002/13026#newcode436
user/src/com/google/gwt/user/client/ui/StackLayoutPanel.java:436: public
void setHeaderHTML(int index, SafeHtml html) {
Since the setHeaderHtml(int, String) version casts the headerwidget to
HasHtml an calls setHTML(String) on it, I wonder if it would make sense
to mirror that here and cast to HasSafeHtml?
Otoh, this would diverge from the usual pattern of delegating
setHTML(SafeHtml) to setHTML(String).
Not sure :)

http://gwt-code-reviews.appspot.com/847801/diff/8002/13030
File user/src/com/google/gwt/user/client/ui/TabBar.java (right):

http://gwt-code-reviews.appspot.com/847801/diff/8002/13030#newcode525
user/src/com/google/gwt/user/client/ui/TabBar.java:525: * {...@link
#setTabText(int, String)} whenever possible.
or {...@link #setTabText(int, SafeHtml)}

http://gwt-code-reviews.appspot.com/847801/diff/8002/13034
File user/test/com/google/gwt/user/client/ui/AnchorTest.java (right):

http://gwt-code-reviews.appspot.com/847801/diff/8002/13034#newcode48
user/test/com/google/gwt/user/client/ui/AnchorTest.java:48: static final
String html = "<b>hello</b><i>world</i>";
should this be private, and HTML?

(here and elsewhere?)

http://gwt-code-reviews.appspot.com/847801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to