http://gwt-code-reviews.appspot.com/841804/diff/1/4 File samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/SummaryWidget.java (right):
http://gwt-code-reviews.appspot.com/841804/diff/1/4#newcode185 samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/SummaryWidget.java:185: void onSelectionChange(@SuppressWarnings("unused") SelectionChangeEvent event) { Unnecessary warning. http://gwt-code-reviews.appspot.com/841804/diff/1/7 File samples/expenses/pom.xml (right): http://gwt-code-reviews.appspot.com/841804/diff/1/7#newcode10 samples/expenses/pom.xml:10: <roo.version>1.1.0.M4</roo.version> Related? http://gwt-code-reviews.appspot.com/841804/diff/1/18 File user/src/com/google/gwt/event/logical/shared/ValueChangeEvent.java (right): http://gwt-code-reviews.appspot.com/841804/diff/1/18#newcode106 user/src/com/google/gwt/event/logical/shared/ValueChangeEvent.java:106: @SuppressWarnings({"unchecked", "rawtypes"}) My eclipse does not know about this warning, and therefore will display a warning. http://gwt-code-reviews.appspot.com/841804/diff/1/19 File user/src/com/google/gwt/event/shared/AbstractEventBus.java (right): http://gwt-code-reviews.appspot.com/841804/diff/1/19#newcode1 user/src/com/google/gwt/event/shared/AbstractEventBus.java:1: package com.google.gwt.event.shared; Copyright? http://gwt-code-reviews.appspot.com/841804/diff/1/19#newcode8 user/src/com/google/gwt/event/shared/AbstractEventBus.java:8: public abstract class AbstractEventBus implements EventBus { Declare unimplemented methods as abstsract so subclasses can use @Override in 1.5 language. http://gwt-code-reviews.appspot.com/841804/diff/1/21 File user/src/com/google/gwt/event/shared/EventBus.java (right): http://gwt-code-reviews.appspot.com/841804/diff/1/21#newcode19 user/src/com/google/gwt/event/shared/EventBus.java:19: * Implemented by objects that dispatch {...@link GwtEvent}s. Add a comment about "global" nomenclature. It's not actually global between instances of an EventBus, is it? http://gwt-code-reviews.appspot.com/841804/diff/1/21#newcode40 user/src/com/google/gwt/event/shared/EventBus.java:40: * . Dangling period. http://gwt-code-reviews.appspot.com/841804/diff/1/21#newcode66 user/src/com/google/gwt/event/shared/EventBus.java:66: * source means that this is a global handler, which shouldreceive all events should receive http://gwt-code-reviews.appspot.com/841804/diff/1/25 File user/src/com/google/gwt/requestfactory/client/impl/ProxyImpl.java (right): http://gwt-code-reviews.appspot.com/841804/diff/1/25#newcode123 user/src/com/google/gwt/requestfactory/client/impl/ProxyImpl.java:123: Extra whitespace. http://gwt-code-reviews.appspot.com/841804/diff/1/26 File user/src/com/google/gwt/requestfactory/client/impl/ProxySchema.java (right): http://gwt-code-reviews.appspot.com/841804/diff/1/26#newcode67 user/src/com/google/gwt/requestfactory/client/impl/ProxySchema.java:67: // Relying on generated code to call only with correct type Can you add an assertion to that effect? http://gwt-code-reviews.appspot.com/841804/diff/1/28 File user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java (right): http://gwt-code-reviews.appspot.com/841804/diff/1/28#newcode308 user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java:308: method.getName(), interfaceType.getName())); Who isn't running their formatter? http://gwt-code-reviews.appspot.com/841804/diff/1/29 File user/src/com/google/gwt/requestfactory/shared/EntityProxyChange.java (right): http://gwt-code-reviews.appspot.com/841804/diff/1/29#newcode55 user/src/com/google/gwt/requestfactory/shared/EntityProxyChange.java:55: TYPE = new Type<EntityProxyChange.Handler<?>>(); The rest of the events eagerly initialize the TYPE field so that the field reference will inline at the locations where the handlers are added. http://gwt-code-reviews.appspot.com/841804/diff/1/29#newcode69 user/src/com/google/gwt/requestfactory/shared/EntityProxyChange.java:69: @SuppressWarnings({"unchecked", "rawtypes"}) rawtypes? http://gwt-code-reviews.appspot.com/841804/diff/1/29#newcode71 user/src/com/google/gwt/requestfactory/shared/EntityProxyChange.java:71: public com.google.gwt.event.shared.GwtEvent.Type<Handler<P>> getAssociatedType() { Use shorter type name here? http://gwt-code-reviews.appspot.com/841804/diff/1/29#newcode73 user/src/com/google/gwt/requestfactory/shared/EntityProxyChange.java:73: // field itself does not, so we have to do an unsafe cast here. block comment http://gwt-code-reviews.appspot.com/841804/diff/1/36 File user/test/com/google/gwt/event/logical/shared/LogicalEventsTest.java (right): http://gwt-code-reviews.appspot.com/841804/diff/1/36#newcode78 user/test/com/google/gwt/event/logical/shared/LogicalEventsTest.java:78: @SuppressWarnings("rawtypes") GwtEvent instance) { Where is this coming from? http://gwt-code-reviews.appspot.com/841804/diff/1/37 File user/test/com/google/gwt/event/shared/CountingEventBus.java (right): http://gwt-code-reviews.appspot.com/841804/diff/1/37#newcode29 user/test/com/google/gwt/event/shared/CountingEventBus.java:29: * for tests. Put it in a testing package? http://gwt-code-reviews.appspot.com/841804/diff/1/37#newcode52 user/test/com/google/gwt/event/shared/CountingEventBus.java:52: counts.put(type, count - 1); This could store values less than one in the map if a handler were repeatedly unregistered. http://gwt-code-reviews.appspot.com/841804/diff/1/38 File user/test/com/google/gwt/event/shared/HandlerManagerTest.java (right): http://gwt-code-reviews.appspot.com/841804/diff/1/38#newcode43 user/test/com/google/gwt/event/shared/HandlerManagerTest.java:43: Unnecessary whitespace. http://gwt-code-reviews.appspot.com/841804/diff/1/39 File user/test/com/google/gwt/event/shared/SimpleEventBusTest.java (right): http://gwt-code-reviews.appspot.com/841804/diff/1/39#newcode29 user/test/com/google/gwt/event/shared/SimpleEventBusTest.java:29: public class SimpleEventBusTest extends HandlerTestBase { If a handler is added multiple times, will it receive the same event more than once? http://gwt-code-reviews.appspot.com/841804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
