Comments for SimpleEventBus.
http://gwt-code-reviews.appspot.com/841804/diff/1/24 File user/src/com/google/gwt/event/shared/SimpleEventBus.java (right): http://gwt-code-reviews.appspot.com/841804/diff/1/24#newcode36 user/src/com/google/gwt/event/shared/SimpleEventBus.java:36: // Add and remove operations received during dispatch. Javadoc comment? http://gwt-code-reviews.appspot.com/841804/diff/1/24#newcode45 user/src/com/google/gwt/event/shared/SimpleEventBus.java:45: SimpleEventBus(boolean fireInReverseOrder) { Document use? http://gwt-code-reviews.appspot.com/841804/diff/1/24#newcode52 user/src/com/google/gwt/event/shared/SimpleEventBus.java:52: assert handler != null : "Cannot add a null handler"; Assertions or IllegalArgumentExceptions for public APIs? http://gwt-code-reviews.appspot.com/841804/diff/1/24#newcode66 user/src/com/google/gwt/event/shared/SimpleEventBus.java:66: public <H extends EventHandler> void removeHandler( Why make this public? http://gwt-code-reviews.appspot.com/841804/diff/1/24#newcode109 user/src/com/google/gwt/event/shared/SimpleEventBus.java:109: event.setSource(source); firingDepth could become negative if this throws an NPE. http://gwt-code-reviews.appspot.com/841804/diff/1/24#newcode120 user/src/com/google/gwt/event/shared/SimpleEventBus.java:120: for (int i = count - 1; i >= 0; i--) { Replace the two for loops with a ListIterator? ListIterator it = isReverseOrder ? list.listIterator(it.size()) : list.listIterator(); while (isReverseOrder ? it.hasPrevious() : it.hasNext()) { H handler = isReverseOrder ? it.previous() : it.next(); } http://gwt-code-reviews.appspot.com/841804/diff/1/24#newcode160 user/src/com/google/gwt/event/shared/SimpleEventBus.java:160: + type; This makes it an error to attempt to remove a handler more than once, which can be done with the public removeHandler() method. http://gwt-code-reviews.appspot.com/841804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
