LGTM so far.
http://gwt-code-reviews.appspot.com/902801/diff/1/26 File user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java (right): http://gwt-code-reviews.appspot.com/902801/diff/1/26#newcode60 user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java:60: What's the purpose of this? For testing purposes until a real encoder is written? http://gwt-code-reviews.appspot.com/902801/diff/1/26#newcode167 user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java:167: Map<String, Class<?>> propertiesFromRecord = getPropertiesFromRecordProxyType(clazz); Maybe just banish the 'record' and call everything proxy for consistency? http://gwt-code-reviews.appspot.com/902801/diff/1/26#newcode343 user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java:343: Why does this static method exist? http://gwt-code-reviews.appspot.com/902801/diff/1/26#newcode1219 user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java:1219: jsonObject.put(ENCODED_ID_PROPERTY, entityKey.encodedId); Would it be better to move this logic into allProperties(EntityKey) so that if there's another callsite of allProperties(), it doesn't have to special case the addition again? http://gwt-code-reviews.appspot.com/902801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
