http://gwt-code-reviews.appspot.com/902801/diff/1/26
File
user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java
(right):
http://gwt-code-reviews.appspot.com/902801/diff/1/26#newcode60
user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java:60:
On 2010/09/20 18:10:45, cromwellian wrote:
What's the purpose of this? For testing purposes until a real encoder
is
written?
No, and I'm going to change it to "alert('boo')" as a test of our json
parsing.
Yes, just to make sure some kind of processing is happening until the
real encoding happens this afternoon.
http://gwt-code-reviews.appspot.com/902801/diff/1/26#newcode167
user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java:167:
Map<String, Class<?>> propertiesFromRecord =
getPropertiesFromRecordProxyType(clazz);
Yeah, I wanted to. I needed to rename things just to figure out what was
going on, but I tried to stick with names that wouldn't result in a sort
and make merging impossible. Thus the strange choices.
On 2010/09/20 18:10:45, cromwellian wrote:
Maybe just banish the 'record' and call everything proxy for
consistency?
http://gwt-code-reviews.appspot.com/902801/diff/1/26#newcode343
user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java:343:
Partial refactoring on the way to making it an instance method. I forgot
to inline it. pdr, you on it?
On 2010/09/20 18:10:45, cromwellian wrote:
Why does this static method exist?
http://gwt-code-reviews.appspot.com/902801/diff/1/26#newcode1219
user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java:1219:
jsonObject.put(ENCODED_ID_PROPERTY, entityKey.encodedId);
On 2010/09/20 18:10:45, cromwellian wrote:
Would it be better to move this logic into allProperties(EntityKey) so
that if
there's another callsite of allProperties(), it doesn't have to
special case the
addition again?
If you say so. I found it hard to tell what gets called when. Is
allProperties universally used?
http://gwt-code-reviews.appspot.com/902801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
