LGTM

http://gwt-code-reviews.appspot.com/880802/diff/22001/23010
File
user/src/com/google/gwt/logging/server/RemoteLoggingServiceUtil.java
(right):

http://gwt-code-reviews.appspot.com/880802/diff/22001/23010#newcode34
user/src/com/google/gwt/logging/server/RemoteLoggingServiceUtil.java:34:
* which will only cause deobfuscation to fail)
nit: Javadoc indentation on @param continuation lines

http://gwt-code-reviews.appspot.com/880802/diff/22001/23010#newcode35
user/src/com/google/gwt/logging/server/RemoteLoggingServiceUtil.java:35:
* @param deobfuscator used for deobfuscation. May be null which will
only
null which  -> null, which

http://gwt-code-reviews.appspot.com/880802/diff/22001/23010#newcode57
user/src/com/google/gwt/logging/server/RemoteLoggingServiceUtil.java:57:
return "";
I think I'd prefer null return value for no errors, but I could be
convinced otherwise.

http://gwt-code-reviews.appspot.com/880802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to