LGTM

http://gwt-code-reviews.appspot.com/880802/diff/19/4027
File
user/src/com/google/gwt/logging/server/RemoteLoggingServiceImpl.java
(right):

http://gwt-code-reviews.appspot.com/880802/diff/19/4027#newcode42
user/src/com/google/gwt/logging/server/RemoteLoggingServiceImpl.java:42:
* Returns either an error message, or null if logging is successful.
2nd sentence should be a @return javadoc?

http://gwt-code-reviews.appspot.com/880802/diff/19/4027#newcode51
user/src/com/google/gwt/logging/server/RemoteLoggingServiceImpl.java:51:
return "Remote logging failed";
Maybe add something like "Check stack trace for details" to the return
message?

http://gwt-code-reviews.appspot.com/880802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to