LGTM

http://gwt-code-reviews.appspot.com/908801/diff/1/5
File
user/src/com/google/gwt/requestfactory/client/impl/ProxyJsoImpl.java
(right):

http://gwt-code-reviews.appspot.com/908801/diff/1/5#newcode192
user/src/com/google/gwt/requestfactory/client/impl/ProxyJsoImpl.java:192:
String schemaAndId[] = relatedId.split("-");
Let's find out later and just land this thing. You would think JS would
do this for us for a literal.

On 2010/09/21 19:30:05, rice wrote:
Would it be more efficient to precompile a regex to do the splitting
whenever
String.split() is called in server code?

http://gwt-code-reviews.appspot.com/908801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to