Updated with the following tests and the fixes to make them work: - setter collection behavior - dummy creates involving collections.
Also did some code cleanup in the files I touched this morning. The warning spam was making it difficult to see newly-introduced problems. http://gwt-code-reviews.appspot.com/921801/diff/1/27 File user/src/com/google/gwt/requestfactory/client/impl/DeltaValueStoreJsonImpl.java (right): http://gwt-code-reviews.appspot.com/921801/diff/1/27#newcode164 user/src/com/google/gwt/requestfactory/client/impl/DeltaValueStoreJsonImpl.java:164: } On 2010/09/24 03:07:59, amitmanjhi wrote:
What is the advantage of putting this in the valueStore?
Old test code to see how things fit together. http://gwt-code-reviews.appspot.com/921801/diff/1/27#newcode165 user/src/com/google/gwt/requestfactory/client/impl/DeltaValueStoreJsonImpl.java:165: assert master.records.containsKey(futureKey); On 2010/09/24 03:07:59, amitmanjhi wrote:
Why are we not firing events here?
The valuestore now fires the create event for future objects. http://gwt-code-reviews.appspot.com/921801/diff/1/29 File user/src/com/google/gwt/requestfactory/client/impl/ProxyImpl.java (right): http://gwt-code-reviews.appspot.com/921801/diff/1/29#newcode100 user/src/com/google/gwt/requestfactory/client/impl/ProxyImpl.java:100: public <V> V get(Property<V> property) { On 2010/09/24 05:19:25, cromwellian wrote:
Missing readthrough to DVS? entity.setList(newList) also mutates the
DVS
property.
Done. http://gwt-code-reviews.appspot.com/921801/diff/1/29#newcode120 user/src/com/google/gwt/requestfactory/client/impl/ProxyImpl.java:120: } On 2010/09/24 03:07:59, amitmanjhi wrote:
Is it documented somewhere that if the return type is an entityProxy,
it
automatically becomes editable?
Editable objects return editable objects. Where is the public-facing documentation? http://gwt-code-reviews.appspot.com/921801/diff/1/34 File user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java (right): http://gwt-code-reviews.appspot.com/921801/diff/1/34#newcode782 user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java:782: entityProxyType.getQualifiedSourceName())); On 2010/09/24 05:19:25, cromwellian wrote:
Is there a need to handle a parameter of type Collection<EntityProxy>?
Done. http://gwt-code-reviews.appspot.com/921801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
