LGTM. I just realized that I had 2 comments on the FavoritesWidget,
other than the on-phone comments about DeltaValueStore. Just nits.


http://gwt-code-reviews.appspot.com/921801/diff/8001/9005
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/FavoritesWidget.java
(right):

http://gwt-code-reviews.appspot.com/921801/diff/8001/9005#newcode161
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/FavoritesWidget.java:161:

Have a map of EntityProxyId, PersonProxy so that the stableId() don't
have to be computed everytime?

http://gwt-code-reviews.appspot.com/921801/diff/8001/9005#newcode178
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/FavoritesWidget.java:178:
}
Can this and the above code be simplified using a LinkedHashMap?

http://gwt-code-reviews.appspot.com/921801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to