LGTM. Other than the comments on wave that you have already looked at, I don't have anything new. I carefully looked at the EntityProxy and stableId stuff, and it looks great. I also skimmed over the generator code.
On Fri, Oct 1, 2010 at 5:50 PM, <[email protected]> wrote: > > Small nit. Besides validation of the context methods themselves, they > also need to be matched up against the service class, I've already done > the @ProxyFor matching part in the patch I sent, so I could do the > @Service matching if you want. > > > > http://gwt-code-reviews.appspot.com/924801/diff/13001/7088 > File > > user/src/com/google/gwt/requestfactory/rebind/model/RequestFactoryModel.java > (right): > > http://gwt-code-reviews.appspot.com/924801/diff/13001/7088#newcode288 > > user/src/com/google/gwt/requestfactory/rebind/model/RequestFactoryModel.java:288: > > This validates that the return type is transportable, but does not > validate that the parameters are transportable. > > > http://gwt-code-reviews.appspot.com/924801/show > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
