I have to admit that I skimmed the code generators. I'm as reviewed as I can be. LGTM once I've looked through the changes we all discussed off line to base update events on the version number
http://gwt-code-reviews.appspot.com/924801/diff/13001/7090 File user/src/com/google/gwt/requestfactory/server/FindService.java (right): http://gwt-code-reviews.appspot.com/924801/diff/13001/7090#newcode18 user/src/com/google/gwt/requestfactory/server/FindService.java:18: Good catch. http://gwt-code-reviews.appspot.com/924801/diff/13001/7096 File user/src/com/google/gwt/requestfactory/shared/Request.java (right): http://gwt-code-reviews.appspot.com/924801/diff/13001/7096#newcode31 user/src/com/google/gwt/requestfactory/shared/Request.java:31: * Submit this requests. Failures will be reported through the global uncaught request, singular http://gwt-code-reviews.appspot.com/924801/diff/13001/7110 File user/test/com/google/gwt/requestfactory/client/EditorTest.java (right): http://gwt-code-reviews.appspot.com/924801/diff/13001/7110#newcode94 user/test/com/google/gwt/requestfactory/client/EditorTest.java:94: private static final int TEST_TIMEOUT = 500000; oops http://gwt-code-reviews.appspot.com/924801/diff/13001/7114 File user/test/com/google/gwt/requestfactory/client/RequestFactoryStringTest.java (right): http://gwt-code-reviews.appspot.com/924801/diff/13001/7114#newcode22 user/test/com/google/gwt/requestfactory/client/RequestFactoryStringTest.java:22: // XXX find a refactoring so this doesn't wind up a copy-and-paste class When? If not tonight, should hold your nose and leave this working. http://gwt-code-reviews.appspot.com/924801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
