http://gwt-code-reviews.appspot.com/975801/diff/1/2 File samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/DynaTableRf.java (right):
http://gwt-code-reviews.appspot.com/975801/diff/1/2#newcode67 samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/DynaTableRf.java:67: mole.show("Error: " + e.getMessage()); How does it go away again? http://gwt-code-reviews.appspot.com/975801/diff/1/12 File samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/ZipPlusFourBox.java (right): http://gwt-code-reviews.appspot.com/975801/diff/1/12#newcode28 samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/ZipPlusFourBox.java:28: * A simple implementation of a US zip code input field. Nice, but it's still pretty odd to store a postal code as a number rather than a string. If rewriting at this point is a bad idea (probably), maybe javadoc to that effect? Will leading zeros work with this? 08550? (NJ!) http://gwt-code-reviews.appspot.com/975801/diff/1/16 File samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/server/PersonSource.java (right): http://gwt-code-reviews.appspot.com/975801/diff/1/16#newcode63 samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/server/PersonSource.java:63: while (toReturn.size() < maxCount && it.hasNext()) { Are you sure this is any more efficient than subList? Seems unlikely. http://gwt-code-reviews.appspot.com/975801/diff/1/20 File user/src/com/google/gwt/editor/client/IsEditor.java (right): http://gwt-code-reviews.appspot.com/975801/diff/1/20#newcode45 user/src/com/google/gwt/editor/client/IsEditor.java:45: * IsEditor instance. What does that mean, "co-editor"? http://gwt-code-reviews.appspot.com/975801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
