LGTM

Only reservation is the finality of the error dialog. Given it's
demo-ware, your call on fixing it.


http://gwt-code-reviews.appspot.com/975801/diff/8001/9002
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/DynaTableRf.java
(right):

http://gwt-code-reviews.appspot.com/975801/diff/8001/9002#newcode78
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/DynaTableRf.java:78:
Logger.getLogger("").addHandler(new ErrorDialog().getHandler());
Nice!

http://gwt-code-reviews.appspot.com/975801/diff/8001/9003
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/ErrorDialog.java
(right):

http://gwt-code-reviews.appspot.com/975801/diff/8001/9003#newcode29
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/ErrorDialog.java:29:
* A simple glasspanel popup that terminates interaction with the
application.
Terminates is pretty severe. Maybe change the text to "An unexpected
error has occurred. You may want to reload the application," and add [
Reload ] [ Dismiss ] buttons?

http://gwt-code-reviews.appspot.com/975801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to