Ready to submit
http://gwt-code-reviews.appspot.com/1013801/diff/1/2 File samples/expenses/src/main/java/com/google/gwt/sample/expenses/ExpensesCommon.gwt.xml (right): http://gwt-code-reviews.appspot.com/1013801/diff/1/2#newcode18 samples/expenses/src/main/java/com/google/gwt/sample/expenses/ExpensesCommon.gwt.xml:18: <inherits name='com.google.gwt.logging.Logging'/> But how life is today. While you're thinking about it, do you want to post an issue for 2_1_1 proposing what to do instead? On 2010/10/15 19:13:49, NotBobV wrote:
Too verbose.
http://gwt-code-reviews.appspot.com/1013801/diff/1/8 File samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesApp.java (right): http://gwt-code-reviews.appspot.com/1013801/diff/1/8#newcode42 samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesApp.java:42: * TODO: This belongs on the server, probably as an entity Might in follow up. But I don't know that I'm going to mess with the server at all in this clean up. On 2010/10/15 19:13:49, NotBobV wrote:
Move to an interface in a shared package?
http://gwt-code-reviews.appspot.com/1013801/diff/1/8#newcode53 samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesApp.java:53: private final PlaceController placeController; On 2010/10/15 19:13:49, NotBobV wrote:
Sort fields?
Done. http://gwt-code-reviews.appspot.com/1013801/diff/1/8#newcode68 samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesApp.java:68: public void run(HasWidgets root) { On 2010/10/15 19:13:49, NotBobV wrote:
doc
Done. http://gwt-code-reviews.appspot.com/1013801/diff/1/8#newcode69 samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesApp.java:69: GWT.setUncaughtExceptionHandler(new GWT.UncaughtExceptionHandler() { Yup. Adding that to the 2.1.1 list. On 2010/10/15 19:13:49, NotBobV wrote:
Wouldn't it make sense for the logging onModuleLoad() to install this
if one is
not already set?
http://gwt-code-reviews.appspot.com/1013801/diff/1/8#newcode114 samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesApp.java:114: // happen onLoad On 2010/10/15 19:13:49, NotBobV wrote:
block comment.
Done. http://gwt-code-reviews.appspot.com/1013801/diff/1/8#newcode118 samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesApp.java:118: /* Browser history integration */ Grumble. That is an idiotic distinction. Done. On 2010/10/15 19:13:49, NotBobV wrote:
Single-line comment
http://gwt-code-reviews.appspot.com/1013801/diff/1/19 File samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ioc/Factory.java (right): http://gwt-code-reviews.appspot.com/1013801/diff/1/19#newcode37 samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ioc/Factory.java:37: public class Factory { Indeed. Extra motivation here is that b/c we use mvn, I could actually get Guice in the works. On 2010/10/15 19:13:49, NotBobV wrote:
DTRF needs this, too.
http://gwt-code-reviews.appspot.com/1013801/diff/1/33 File samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/place/ReportListPlace.java (right): http://gwt-code-reviews.appspot.com/1013801/diff/1/33#newcode32 samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/place/ReportListPlace.java:32: * Tokenizer. Extremely On 2010/10/15 19:13:49, NotBobV wrote:
Isn't it?
http://gwt-code-reviews.appspot.com/1013801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
