http://gwt-code-reviews.appspot.com/1013801/diff/1/2 File samples/expenses/src/main/java/com/google/gwt/sample/expenses/ExpensesCommon.gwt.xml (right):
http://gwt-code-reviews.appspot.com/1013801/diff/1/2#newcode18 samples/expenses/src/main/java/com/google/gwt/sample/expenses/ExpensesCommon.gwt.xml:18: <inherits name='com.google.gwt.logging.Logging'/> Too verbose. http://gwt-code-reviews.appspot.com/1013801/diff/1/3 File samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/Approval.java (right): http://gwt-code-reviews.appspot.com/1013801/diff/1/3#newcode1 samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/Approval.java:1: package com.google.gwt.sample.expenses.client; Copyright. http://gwt-code-reviews.appspot.com/1013801/diff/1/8 File samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesApp.java (right): http://gwt-code-reviews.appspot.com/1013801/diff/1/8#newcode42 samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesApp.java:42: * TODO: This belongs on the server, probably as an entity Move to an interface in a shared package? http://gwt-code-reviews.appspot.com/1013801/diff/1/8#newcode53 samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesApp.java:53: private final PlaceController placeController; Sort fields? http://gwt-code-reviews.appspot.com/1013801/diff/1/8#newcode68 samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesApp.java:68: public void run(HasWidgets root) { doc http://gwt-code-reviews.appspot.com/1013801/diff/1/8#newcode69 samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesApp.java:69: GWT.setUncaughtExceptionHandler(new GWT.UncaughtExceptionHandler() { Wouldn't it make sense for the logging onModuleLoad() to install this if one is not already set? http://gwt-code-reviews.appspot.com/1013801/diff/1/8#newcode114 samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesApp.java:114: // happen onLoad block comment. http://gwt-code-reviews.appspot.com/1013801/diff/1/8#newcode118 samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesApp.java:118: /* Browser history integration */ Single-line comment http://gwt-code-reviews.appspot.com/1013801/diff/1/19 File samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ioc/Factory.java (right): http://gwt-code-reviews.appspot.com/1013801/diff/1/19#newcode37 samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ioc/Factory.java:37: public class Factory { DTRF needs this, too. http://gwt-code-reviews.appspot.com/1013801/diff/1/24 File samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/place/ExpensesPlaceHistoryMapper.java (right): http://gwt-code-reviews.appspot.com/1013801/diff/1/24#newcode1 samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/place/ExpensesPlaceHistoryMapper.java:1: package com.google.gwt.sample.expenses.client.place; Copyright. http://gwt-code-reviews.appspot.com/1013801/diff/1/33 File samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/place/ReportListPlace.java (right): http://gwt-code-reviews.appspot.com/1013801/diff/1/33#newcode32 samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/place/ReportListPlace.java:32: * Tokenizer. Isn't it? http://gwt-code-reviews.appspot.com/1013801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
