http://gwt-code-reviews.appspot.com/1030801/diff/1/2
File user/src/com/google/gwt/resources/rg/ImageBundleBuilder.java
(right):

http://gwt-code-reviews.appspot.com/1030801/diff/1/2#newcode561
user/src/com/google/gwt/resources/rg/ImageBundleBuilder.java:561: throw
new IOException("No " + BUNDLE_FILE_TYPE + " writer available");
rather than cascading the exception, would be better to throw
UnableToComplete exception from here (or would you have to catch it
since it is in a try block?)

http://gwt-code-reviews.appspot.com/1030801/diff/1/2#newcode562
user/src/com/google/gwt/resources/rg/ImageBundleBuilder.java:562: } else
{
unnecessary else

http://gwt-code-reviews.appspot.com/1030801/diff/1/2#newcode567
user/src/com/google/gwt/resources/rg/ImageBundleBuilder.java:567:
"Unable to generate file name for image bundle file", e);
Is this message accurate?  what does the file name have to do with the
problem?

http://gwt-code-reviews.appspot.com/1030801/diff/1/3
File user/src/com/google/gwt/user/rebind/ui/ImageBundleBuilder.java
(right):

http://gwt-code-reviews.appspot.com/1030801/diff/1/3#newcode333
user/src/com/google/gwt/user/rebind/ui/ImageBundleBuilder.java:333: }
else {
unnecessary else.

http://gwt-code-reviews.appspot.com/1030801/diff/1/3#newcode338
user/src/com/google/gwt/user/rebind/ui/ImageBundleBuilder.java:338:
"Unable to generate file name for image bundle file.", e);
Is this message accurate?  what does the file name have to do with the
problem?

http://gwt-code-reviews.appspot.com/1030801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to