patch updated.

http://gwt-code-reviews.appspot.com/1030801/diff/1/2
File user/src/com/google/gwt/resources/rg/ImageBundleBuilder.java
(right):

http://gwt-code-reviews.appspot.com/1030801/diff/1/2#newcode561
user/src/com/google/gwt/resources/rg/ImageBundleBuilder.java:561: throw
new IOException("No " + BUNDLE_FILE_TYPE + " writer available");
On 2010/10/19 16:20:12, zundel wrote:
rather than cascading the exception, would be better to throw
UnableToComplete
exception from here (or would you have to catch it since it is in a
try block?)

i was just trying to reuse the log statement, but i can throw it
directly.

http://gwt-code-reviews.appspot.com/1030801/diff/1/2#newcode567
user/src/com/google/gwt/resources/rg/ImageBundleBuilder.java:567:
"Unable to generate file name for image bundle file", e);
On 2010/10/19 16:20:12, zundel wrote:
Is this message accurate?  what does the file name have to do with the
problem?

no, though it was wrong before this patch. i'll update it.

http://gwt-code-reviews.appspot.com/1030801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to