Some comments on style

http://gwt-code-reviews.appspot.com/1015801/diff/6001/7001
File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
(right):

http://gwt-code-reviews.appspot.com/1015801/diff/6001/7001#newcode771
dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java:771:
// enum ordinalization (try to replace enum references with integer
ordinal)
Since this is a new optimizer, maybe we should move invocation to inside
of the isAggresivelyOptimize test so it could be easily disabled if we
suspect a problem?

http://gwt-code-reviews.appspot.com/1015801/diff/6001/7003
File dev/core/src/com/google/gwt/dev/jjs/impl/AstDumper.java (right):

http://gwt-code-reviews.appspot.com/1015801/diff/6001/7003#newcode46
dev/core/src/com/google/gwt/dev/jjs/impl/AstDumper.java:46:
maybeDumpAST(jprogram,null,true);
style nit: space following comma in parameter list (same throughout)

http://gwt-code-reviews.appspot.com/1015801/diff/6001/7003#newcode98
dev/core/src/com/google/gwt/dev/jjs/impl/AstDumper.java:98: pw.close();
Isn't the pw.flush() redudnant with pw.close()?

http://gwt-code-reviews.appspot.com/1015801/diff/6001/7005
File
dev/core/src/com/google/gwt/dev/jjs/impl/ImplicitUpcastAnalyzer.java
(right):

http://gwt-code-reviews.appspot.com/1015801/diff/6001/7005#newcode42
dev/core/src/com/google/gwt/dev/jjs/impl/ImplicitUpcastAnalyzer.java:42:
* TODO: Consider extending to handle implicit upcasts between primitive
types.
TODOs need a name after them - e.g. TODO(zundel):

http://gwt-code-reviews.appspot.com/1015801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to