Very nice, great unit tests! I have questions over the need to blacklist static functions just because they're enclosed by an Enum (is Enum.staticMethod() any different than UtilClass.staticMethod()?) and a slight edge case with multidimensional enum arrays.
http://gwt-code-reviews.appspot.com/1015801/diff/13001/14004 File dev/core/src/com/google/gwt/dev/jjs/impl/EnumOrdinalizer.java (right): http://gwt-code-reviews.appspot.com/1015801/diff/13001/14004#newcode349 dev/core/src/com/google/gwt/dev/jjs/impl/EnumOrdinalizer.java:349: blackListIfEnum(x.getTarget().getEnclosingType()); Do we really need to blacklist other static methods? http://gwt-code-reviews.appspot.com/1015801/diff/13001/14004#newcode757 dev/core/src/com/google/gwt/dev/jjs/impl/EnumOrdinalizer.java:757: // Bail if we don't nkeyeed to do any ordinalization spelling http://gwt-code-reviews.appspot.com/1015801/diff/13001/14004#newcode794 dev/core/src/com/google/gwt/dev/jjs/impl/EnumOrdinalizer.java:794: if (type instanceof JArrayType) { Does this need to be recursive? What of Enum[][]? http://gwt-code-reviews.appspot.com/1015801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
