LGTM. Comments are advisory only.

http://gwt-code-reviews.appspot.com/867801/diff/12001/13003
File user/src/com/google/gwt/dom/client/NativeEvent.java (right):

http://gwt-code-reviews.appspot.com/867801/diff/12001/13003#newcode72
user/src/com/google/gwt/dom/client/NativeEvent.java:72: return
DOMImpl.impl.getChangedTouches(this);
It's unfortunate that there's no way to put these methods elsewhere, but
I suppose we have no choice until we find a way to refactor the event
hierarchy... :(

http://gwt-code-reviews.appspot.com/867801/diff/12001/13004
File user/src/com/google/gwt/dom/client/Touch.java (right):

http://gwt-code-reviews.appspot.com/867801/diff/12001/13004#newcode25
user/src/com/google/gwt/dom/client/Touch.java:25: public class Touch
extends JavaScriptObject {
FWIW, it wasn't strictly necessary to add all the shims to DOMImpl for
these methods, since we don't have any need to create separate browser
versions of them. But it won't hurt anything either (IOW, don't refactor
it on account of this).

http://gwt-code-reviews.appspot.com/867801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to