This is looking great! I created a test app and noticed that multitouch does not work on the Android/Froyo browser (not your fault.) If you don't mind waiting a day, I'll pick up an iPhone and make sure the gesture and multitouch events are working there.
A lot of comments below, but almost all nits. http://gwt-code-reviews.appspot.com/867801/diff/12001/13006 File user/src/com/google/gwt/event/dom/client/GestureChangeEvent.java (right): http://gwt-code-reviews.appspot.com/867801/diff/12001/13006#newcode41 user/src/com/google/gwt/event/dom/client/GestureChangeEvent.java:41: * {...@link DomEvent#fireNativeEvent(com.google.gwt.dom.client.NativeEvent, com.google.gwt.event.shared.HasHandlers)} Line length > 100chars. http://gwt-code-reviews.appspot.com/867801/diff/12001/13008 File user/src/com/google/gwt/event/dom/client/GestureEndEvent.java (right): http://gwt-code-reviews.appspot.com/867801/diff/12001/13008#newcode41 user/src/com/google/gwt/event/dom/client/GestureEndEvent.java:41: * {...@link DomEvent#fireNativeEvent(com.google.gwt.dom.client.NativeEvent, com.google.gwt.event.shared.HasHandlers)} Line length > 100chars. http://gwt-code-reviews.appspot.com/867801/diff/12001/13008#newcode64 user/src/com/google/gwt/event/dom/client/GestureEndEvent.java:64: Extra space. http://gwt-code-reviews.appspot.com/867801/diff/12001/13010 File user/src/com/google/gwt/event/dom/client/GestureStartEvent.java (right): http://gwt-code-reviews.appspot.com/867801/diff/12001/13010#newcode41 user/src/com/google/gwt/event/dom/client/GestureStartEvent.java:41: * {...@link DomEvent#fireNativeEvent(com.google.gwt.dom.client.NativeEvent, com.google.gwt.event.shared.HasHandlers)} Line length > 100chars. http://gwt-code-reviews.appspot.com/867801/diff/12001/13024 File user/src/com/google/gwt/event/dom/client/TouchCancelEvent.java (right): http://gwt-code-reviews.appspot.com/867801/diff/12001/13024#newcode41 user/src/com/google/gwt/event/dom/client/TouchCancelEvent.java:41: * {...@link DomEvent#fireNativeEvent(com.google.gwt.dom.client.NativeEvent, com.google.gwt.event.shared.HasHandlers)} Line length > 100chars. http://gwt-code-reviews.appspot.com/867801/diff/12001/13024#newcode56 user/src/com/google/gwt/event/dom/client/TouchCancelEvent.java:56: Extra newline. http://gwt-code-reviews.appspot.com/867801/diff/12001/13026 File user/src/com/google/gwt/event/dom/client/TouchEndEvent.java (right): http://gwt-code-reviews.appspot.com/867801/diff/12001/13026#newcode41 user/src/com/google/gwt/event/dom/client/TouchEndEvent.java:41: * {...@link DomEvent#fireNativeEvent(com.google.gwt.dom.client.NativeEvent, com.google.gwt.event.shared.HasHandlers)} Line length > 100chars. http://gwt-code-reviews.appspot.com/867801/diff/12001/13026#newcode56 user/src/com/google/gwt/event/dom/client/TouchEndEvent.java:56: Extra newline. http://gwt-code-reviews.appspot.com/867801/diff/12001/13028 File user/src/com/google/gwt/event/dom/client/TouchEvent.java (right): http://gwt-code-reviews.appspot.com/867801/diff/12001/13028#newcode24 user/src/com/google/gwt/event/dom/client/TouchEvent.java:24: * @see http://developer.apple.com/library/safari/documentation/UserExperience/Reference/TouchEventClassReference/TouchEvent/TouchEvent.html Line length > 100chars. http://gwt-code-reviews.appspot.com/867801/diff/12001/13029 File user/src/com/google/gwt/event/dom/client/TouchMoveEvent.java (right): http://gwt-code-reviews.appspot.com/867801/diff/12001/13029#newcode41 user/src/com/google/gwt/event/dom/client/TouchMoveEvent.java:41: * {...@link DomEvent#fireNativeEvent(com.google.gwt.dom.client.NativeEvent, com.google.gwt.event.shared.HasHandlers)} Line length > 100chars. http://gwt-code-reviews.appspot.com/867801/diff/12001/13029#newcode56 user/src/com/google/gwt/event/dom/client/TouchMoveEvent.java:56: Extra newline. http://gwt-code-reviews.appspot.com/867801/diff/12001/13031 File user/src/com/google/gwt/event/dom/client/TouchStartEvent.java (right): http://gwt-code-reviews.appspot.com/867801/diff/12001/13031#newcode41 user/src/com/google/gwt/event/dom/client/TouchStartEvent.java:41: * {...@link DomEvent#fireNativeEvent(com.google.gwt.dom.client.NativeEvent, com.google.gwt.event.shared.HasHandlers)} Line length > 100chars. http://gwt-code-reviews.appspot.com/867801/diff/12001/13031#newcode56 user/src/com/google/gwt/event/dom/client/TouchStartEvent.java:56: Extra newline. http://gwt-code-reviews.appspot.com/867801/diff/12001/13036 File user/src/com/google/gwt/user/client/impl/DOMImplStandard.java (right): http://gwt-code-reviews.appspot.com/867801/diff/12001/13036#newcode209 user/src/com/google/gwt/user/client/impl/DOMImplStandard.java:209: $wnd.addEventListener('touchcanel', @com.google.gwt.user.client.impl.DOMImplStandard::dispatchCapturedMouseEvent, true); typo: 'touchcanel' should be 'touchcancel' http://gwt-code-reviews.appspot.com/867801/diff/12001/13041 File user/test/com/google/gwt/user/client/GestureEventSinkTest.java (right): http://gwt-code-reviews.appspot.com/867801/diff/12001/13041#newcode57 user/test/com/google/gwt/user/client/GestureEventSinkTest.java:57: assertNotSame(0, Event.ONTOUCHCHANGE); Should be Event.ONTOUCHCANCEL, not ONTOUCHCHANGE http://gwt-code-reviews.appspot.com/867801/diff/12001/13041#newcode79 user/test/com/google/gwt/user/client/GestureEventSinkTest.java:79: Formatting (spaces) http://gwt-code-reviews.appspot.com/867801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
