http://gwt-code-reviews.appspot.com/1078801/diff/1/2 File user/src/com/google/gwt/user/cellview/client/AbstractHasData.java (right):
http://gwt-code-reviews.appspot.com/1078801/diff/1/2#newcode631 user/src/com/google/gwt/user/cellview/client/AbstractHasData.java:631: * Space after star (happens throughout patch). http://gwt-code-reviews.appspot.com/1078801/diff/1/2#newcode638 user/src/com/google/gwt/user/cellview/client/AbstractHasData.java:638: : keyProvider.getKey(value); Will it never be the case that an object with a valid key is set to null? http://gwt-code-reviews.appspot.com/1078801/diff/1/5 File user/src/com/google/gwt/user/cellview/client/CellList.java (right): http://gwt-code-reviews.appspot.com/1078801/diff/1/5#newcode242 user/src/com/google/gwt/user/cellview/client/CellList.java:242: getPresenter().flush(); Does this change the way that getRowElement is used? Seems like a risk to users who call this in existing code. http://gwt-code-reviews.appspot.com/1078801/diff/1/9 File user/src/com/google/gwt/user/cellview/client/HasDataPresenter.java (right): http://gwt-code-reviews.appspot.com/1078801/diff/1/9#newcode871 user/src/com/google/gwt/user/cellview/client/HasDataPresenter.java:871: setRowCount(valuesEnd, isRowCountExact()); Why is this using valuesEnd rather than valuesLength? http://gwt-code-reviews.appspot.com/1078801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
