http://gwt-code-reviews.appspot.com/1078801/diff/1/2 File user/src/com/google/gwt/user/cellview/client/AbstractHasData.java (right):
http://gwt-code-reviews.appspot.com/1078801/diff/1/2#newcode631 user/src/com/google/gwt/user/cellview/client/AbstractHasData.java:631: * Eclipse 3.5 formatter took out the spaces and Eclipse 3.6 formatter adds them back in. I'll remove them before committing. http://gwt-code-reviews.appspot.com/1078801/diff/1/2#newcode638 user/src/com/google/gwt/user/cellview/client/AbstractHasData.java:638: : keyProvider.getKey(value); I think its a matter of definition. Technically you could say that null is a valid value, and a key provider could provide an arbitrary key. However, its more likely that it will result in an NPE, and that if it doesn't result in an NPE, the user would just return null anyway. http://gwt-code-reviews.appspot.com/1078801/diff/1/5 File user/src/com/google/gwt/user/cellview/client/CellList.java (right): http://gwt-code-reviews.appspot.com/1078801/diff/1/5#newcode242 user/src/com/google/gwt/user/cellview/client/CellList.java:242: getPresenter().flush(); Its actually here for backward compatibility. If a user calls getRowElement(), we resolve the pending changes and give them the row element that would be there if the table had been created synchronously. If however they are in the middle of rendering a pending CL, we just give them the current row element, because we cannot resolve the state while rendering. http://gwt-code-reviews.appspot.com/1078801/diff/1/9 File user/src/com/google/gwt/user/cellview/client/HasDataPresenter.java (right): http://gwt-code-reviews.appspot.com/1078801/diff/1/9#newcode871 user/src/com/google/gwt/user/cellview/client/HasDataPresenter.java:871: setRowCount(valuesEnd, isRowCountExact()); rowCount refers to the total row count, not the page size. This code is checking if the data that was passed in exceeds the total row count, and automatically adjusts the total row count accordingly. For example, if you think you have 100 rows but you set values 90-110, then we know that you have 110 rows. valuesEnd accounts for the pageStart index, whereas values.length() does not. http://gwt-code-reviews.appspot.com/1078801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
