[gwt-contrib] Public: Handle constraints on Primitive fields. (issue1110801)

[nchalko]

Reviewers: rchandia,

Description:
Public:  Handle constraints on Primitive fields.
Add TCK test to excercise primitives.

Please review this at http://gwt-code-reviews.appspot.com/1110801/show

Affected files:
  M  
samples/validation/src/com/google/gwt/sample/validation/shared/Person.java
  M  
samples/validationtck/src/com/google/gwt/sample/validationtck/TckValidator.java
  M  
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java


Index:  
samples/validation/src/com/google/gwt/sample/validation/shared/Person.java
===================================================================
---  
samples/validation/src/com/google/gwt/sample/validation/shared/Person.java	 
(revision 9233)
+++  
samples/validation/src/com/google/gwt/sample/validation/shared/Person.java	 
(working copy)
@@ -17,6 +17,7 @@

 import com.google.gwt.user.client.rpc.IsSerializable;

+import javax.validation.constraints.Max;
 import javax.validation.constraints.NotNull;
 import javax.validation.constraints.Size;

@@ -30,11 +31,23 @@
   @Size(min = 4)
   private String name;

+  @Max(999999999)
+  private long ssn;
+
   public String getName() {
     return name;
   }

   public void setName(String name) {
     this.name = name;
+
+  }
+
+  public long getSsn() {
+    return ssn;
+  }
+
+  public void setSsn(long ssn) {
+    this.ssn = ssn;
   }
 }
Index:  
samples/validationtck/src/com/google/gwt/sample/validationtck/TckValidator.java
===================================================================
---  
samples/validationtck/src/com/google/gwt/sample/validationtck/TckValidator.java	 
(revision 9233)
+++  
samples/validationtck/src/com/google/gwt/sample/validationtck/TckValidator.java	 
(working copy)
@@ -17,6 +17,7 @@

 import com.google.gwt.validation.client.GwtValidation;

+import org.hibernate.jsr303.tck.tests.constraints.application.Building;
 import org.hibernate.jsr303.tck.tests.constraints.application.SuperWoman;
 import org.hibernate.jsr303.tck.tests.constraints.application.Woman;

@@ -26,8 +27,9 @@
  * Top Level validator for the TCK tests
  */
 @GwtValidation(value = {
-    Woman.class,
-    SuperWoman.class
+    Building.class,
+    SuperWoman.class,
+    Woman.class
     })
 public interface TckValidator extends Validator {
 }
Index:  
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java
===================================================================
---  
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java	 
(revision 9233)
+++  
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java	 
(working copy)
@@ -24,6 +24,7 @@
 import com.google.gwt.core.ext.typeinfo.NotFoundException;
 import com.google.gwt.core.ext.typeinfo.TypeOracle;
 import com.google.gwt.dev.jjs.ast.JProgram;
+import com.google.gwt.thirdparty.guava.common.primitives.Primitives;
 import com.google.gwt.user.rebind.ClassSourceFileComposerFactory;
 import com.google.gwt.user.rebind.SourceWriter;
 import com.google.gwt.validation.client.impl.AbstractGwtSpecificValidator;
@@ -664,7 +665,7 @@
       sw.print("violations, ");
       sw.print("null, ");
       sw.print("(");
-      sw.print(property.getElementClass().getCanonicalName());
+       
sw.print(Primitives.wrap(property.getElementClass()).getCanonicalName());
       sw.print(") value, ");
       sw.println("groups);");



--
http://groups.google.com/group/Google-Web-Toolkit-Contributors