http://gwt-code-reviews.appspot.com/1108801/diff/1/7
File dev/core/src/com/google/gwt/dev/js/ast/JsName.java (right):

http://gwt-code-reviews.appspot.com/1108801/diff/1/7#newcode78
dev/core/src/com/google/gwt/dev/js/ast/JsName.java:78: this.shortIdent =
StringInterner.get().intern(shortIdent);
ah, good call. i should've had this one already.

http://gwt-code-reviews.appspot.com/1108801/diff/1/9
File dev/core/src/com/google/gwt/dev/util/StringInterner.java (right):

http://gwt-code-reviews.appspot.com/1108801/diff/1/9#newcode60
dev/core/src/com/google/gwt/dev/util/StringInterner.java:60: }
this seems reasonable enough to me--though I wonder if it's really
necessary.

out of curiosity, did you measure how much of a speedup this gave over
the normal interning call (which is really just a get on a hash map)?

http://gwt-code-reviews.appspot.com/1108801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to