LGTM. Only mostly cosmetic nits. This CL does not contain tests for violations in value proxies, right?
http://gwt-code-reviews.appspot.com/1108802/diff/1/20 File user/src/com/google/gwt/requestfactory/server/RequestFactoryInterfaceValidator.java (right): http://gwt-code-reviews.appspot.com/1108802/diff/1/20#newcode1239 user/src/com/google/gwt/requestfactory/server/RequestFactoryInterfaceValidator.java:1239: * Examine the arguments ond return value of a method and check any ond -> and http://gwt-code-reviews.appspot.com/1108802/diff/1/20#newcode1252 user/src/com/google/gwt/requestfactory/server/RequestFactoryInterfaceValidator.java:1252: // Check EntityProxy args ond return types against the domain ond -> and http://gwt-code-reviews.appspot.com/1108802/diff/1/22 File user/src/com/google/gwt/requestfactory/server/Resolver.java (right): http://gwt-code-reviews.appspot.com/1108802/diff/1/22#newcode91 user/src/com/google/gwt/requestfactory/server/Resolver.java:91: * Used to map the objecting being resolved and its API slice to the objecting -> object http://gwt-code-reviews.appspot.com/1108802/diff/1/22#newcode185 user/src/com/google/gwt/requestfactory/server/Resolver.java:185: * Given a method a domain object, return a value that can be encoded by the Fix javadoc http://gwt-code-reviews.appspot.com/1108802/diff/1/22#newcode203 user/src/com/google/gwt/requestfactory/server/Resolver.java:203: * @param the client object to resolve missing param name http://gwt-code-reviews.appspot.com/1108802/diff/1/27 File user/src/com/google/gwt/requestfactory/shared/RequestContext.java (left): http://gwt-code-reviews.appspot.com/1108802/diff/1/27#oldcode28 user/src/com/google/gwt/requestfactory/shared/RequestContext.java:28: * @return an {...@link EntityProxy} instance of type T No longer returns an EntityProxy http://gwt-code-reviews.appspot.com/1108802/diff/1/29 File user/src/com/google/gwt/requestfactory/shared/Violation.java (right): http://gwt-code-reviews.appspot.com/1108802/diff/1/29#newcode46 user/src/com/google/gwt/requestfactory/shared/Violation.java:46: * method will return a ValueProxy that contains the invalid values. Document the way to discern whether the violation happened in an EntityProxy or a ValueProxy. http://gwt-code-reviews.appspot.com/1108802/diff/1/30 File user/src/com/google/gwt/requestfactory/shared/impl/AbstractRequestContext.java (left): http://gwt-code-reviews.appspot.com/1108802/diff/1/30#oldcode385 user/src/com/google/gwt/requestfactory/shared/impl/AbstractRequestContext.java:385: * Resolves an IdMessage into an EntityProxyId. SimpleEntityProxyId http://gwt-code-reviews.appspot.com/1108802/diff/1/35 File user/src/com/google/gwt/requestfactory/shared/impl/EntityProxyCategory.java (right): http://gwt-code-reviews.appspot.com/1108802/diff/1/35#newcode31 user/src/com/google/gwt/requestfactory/shared/impl/EntityProxyCategory.java:31: * ValueProxies are equal if they are from the same RequestContext and their This seems to compare EntityProxies instead of ValueProxies http://gwt-code-reviews.appspot.com/1108802/diff/1/41 File user/src/com/google/gwt/requestfactory/shared/impl/SimpleProxyId.java (right): http://gwt-code-reviews.appspot.com/1108802/diff/1/41#newcode22 user/src/com/google/gwt/requestfactory/shared/impl/SimpleProxyId.java:22: * The base implementation of id objects in the RequestFactory system. This This... http://gwt-code-reviews.appspot.com/1108802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
