http://gwt-code-reviews.appspot.com/1129801/diff/4001/5008 File samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/ContactTreeViewModel.java (right):
http://gwt-code-reviews.appspot.com/1129801/diff/4001/5008#newcode199 samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/ContactTreeViewModel.java:199: Extra newlines http://gwt-code-reviews.appspot.com/1129801/diff/4001/5024 File user/src/com/google/gwt/cell/client/Cell.java (right): http://gwt-code-reviews.appspot.com/1129801/diff/4001/5024#newcode65 user/src/com/google/gwt/cell/client/Cell.java:65: context.key = key; Why is the value contained in the Context? I think it would be better to let the Cell maintain it's own state, and pass in the Context for rendering, etc., as needed. If you went this route, it would mean changing many of the methods to accept both a value and an accompanying Context. Constructors could accept just a value, or a value and a Context. http://gwt-code-reviews.appspot.com/1129801/diff/4001/5024#newcode180 user/src/com/google/gwt/cell/client/Cell.java:180: * may chooses to pass keystrokes directly to the cell rather than using them chooses -> choose http://gwt-code-reviews.appspot.com/1129801/diff/4001/5038 File user/src/com/google/gwt/cell/client/TextCell.java (right): http://gwt-code-reviews.appspot.com/1129801/diff/4001/5038#newcode47 user/src/com/google/gwt/cell/client/TextCell.java:47: public void render(Context<String> context, SafeHtml value, SafeHtmlBuilder sb) { Why pass both context.getValue() and SafeHtml value? Won't they be the same? http://gwt-code-reviews.appspot.com/1129801/diff/4001/5043 File user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java (right): http://gwt-code-reviews.appspot.com/1129801/diff/4001/5043#newcode67 user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java:67: // TODO(jlabanca): Convert this to be the type of the child and create lazily. Suggestion: implementors might refer to this test and it would be nice to have this TODO for reference. http://gwt-code-reviews.appspot.com/1129801/diff/4001/5061 File user/test/com/google/gwt/user/cellview/client/ColumnTest.java (right): http://gwt-code-reviews.appspot.com/1129801/diff/4001/5061#newcode26 user/test/com/google/gwt/user/cellview/client/ColumnTest.java:26: import com.google.gwt.emultest.java.lang.C; Unneeded import http://gwt-code-reviews.appspot.com/1129801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
