http://gwt-code-reviews.appspot.com/1129801/diff/4001/5038 File user/src/com/google/gwt/cell/client/TextCell.java (right):
http://gwt-code-reviews.appspot.com/1129801/diff/4001/5038#newcode47 user/src/com/google/gwt/cell/client/TextCell.java:47: public void render(Context<String> context, SafeHtml value, SafeHtmlBuilder sb) { On 2010/11/24 19:50:06, pdr wrote:
Why pass both context.getValue() and SafeHtml value? Won't they be the
same? Ditto. http://gwt-code-reviews.appspot.com/1129801/diff/4001/5041 File user/src/com/google/gwt/user/cellview/client/CellList.java (right): http://gwt-code-reviews.appspot.com/1129801/diff/4001/5041#newcode325 user/src/com/google/gwt/user/cellview/client/CellList.java:325: * Is this going to be a problem for asynchronous edits? If multiple calls are accessing the singleton context at once this could spell bad news. http://gwt-code-reviews.appspot.com/1129801/diff/4001/5042 File user/src/com/google/gwt/user/cellview/client/CellTable.java (right): http://gwt-code-reviews.appspot.com/1129801/diff/4001/5042#newcode342 user/src/com/google/gwt/user/cellview/client/CellTable.java:342: final T rowValue, NativeEvent event) { Why not pass a Context here (and in subsequent functions)? http://gwt-code-reviews.appspot.com/1129801/diff/4001/5042#newcode353 user/src/com/google/gwt/user/cellview/client/CellTable.java:353: * Same concern here as with CellList since edits are asynchronous. Can you assume that only one method at a time is accessing this Context? http://gwt-code-reviews.appspot.com/1129801/diff/4001/5042#newcode1152 user/src/com/google/gwt/user/cellview/client/CellTable.java:1152: CellPreviewEvent<T> previewEvent = CellPreviewEvent.fire(this, event, Why isn't CellPreviewEvent being updated to use Contexts? http://gwt-code-reviews.appspot.com/1129801/diff/4001/5051 File user/test/com/google/gwt/cell/client/CompositeCellTest.java (right): http://gwt-code-reviews.appspot.com/1129801/diff/4001/5051#newcode115 user/test/com/google/gwt/cell/client/CompositeCellTest.java:115: cell.onBrowserEvent(context, event, null); It seems like there is more in depth testing to be done with Contexts for composite cells. http://gwt-code-reviews.appspot.com/1129801/diff/4001/5055 File user/test/com/google/gwt/cell/client/ImageLoadingCellTest.java (right): http://gwt-code-reviews.appspot.com/1129801/diff/4001/5055#newcode61 user/test/com/google/gwt/cell/client/ImageLoadingCellTest.java:61: // Verify the image. Is this expected to pass with negative indices? http://gwt-code-reviews.appspot.com/1129801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
