Addressed feedback and moved StyleTest and XMLTest to separate issues:
Re-enable a few style tests now that old linux hosted mode is gone http://gwt-code-reviews.appspot.com/1228801 Re-enable XML parse test, which was previously failing in one Safari configuration in Production Mode in the 1.5 release branch http://gwt-code-reviews.appspot.com/1229801 http://gwt-code-reviews.appspot.com/1221801/diff/1/35 File user/src/com/google/gwt/rpc/client/impl/SimplePayloadSink.java (right): http://gwt-code-reviews.appspot.com/1221801/diff/1/35#newcode195 user/src/com/google/gwt/rpc/client/impl/SimplePayloadSink.java:195: * In hosted-mode, the field's declaring class is written to the stream to On 2010/12/15 23:49:34, zundel wrote:
s/hosted-mode/Development Mode
Done. http://gwt-code-reviews.appspot.com/1221801/diff/1/40 File user/src/com/google/gwt/safehtml/shared/SafeHtmlHostedModeUtils.java (right): http://gwt-code-reviews.appspot.com/1221801/diff/1/40#newcode25 user/src/com/google/gwt/safehtml/shared/SafeHtmlHostedModeUtils.java:25: * SafeHtml utilities whose implementation differs between hosted and Production On 2010/12/15 23:49:34, zundel wrote:
s/hosted/Development
Done. http://gwt-code-reviews.appspot.com/1221801/diff/1/40#newcode29 user/src/com/google/gwt/safehtml/shared/SafeHtmlHostedModeUtils.java:29: * This class has a super-source peer that provides the web-mode implementation. On 2010/12/15 23:49:34, zundel wrote:
s/web-mode/Production Mode
Done. http://gwt-code-reviews.appspot.com/1221801/diff/1/41 File user/src/com/google/gwt/safehtml/shared/SafeHtmlUtils.java (right): http://gwt-code-reviews.appspot.com/1221801/diff/1/41#newcode71 user/src/com/google/gwt/safehtml/shared/SafeHtmlUtils.java:71: * details). For performance reasons, this check is not performed in prod mode On 2010/12/15 23:49:34, zundel wrote:
s/prod/Production Mode ?
Done. http://gwt-code-reviews.appspot.com/1221801/diff/1/41#newcode76 user/src/com/google/gwt/safehtml/shared/SafeHtmlUtils.java:76: * @throws IllegalArgumentException if not running in prod mode and {...@code On 2010/12/15 23:49:34, zundel wrote:
s/prod/Production Mode ?
Done. http://gwt-code-reviews.appspot.com/1221801/diff/1/52 File user/test/com/google/gwt/core/ext/linker/impl/SelectionScriptLinkerUnitTest.java (right): http://gwt-code-reviews.appspot.com/1221801/diff/1/52#newcode207 user/test/com/google/gwt/core/ext/linker/impl/SelectionScriptLinkerUnitTest.java:207: // hosted On 2010/12/15 23:49:34, zundel wrote:
Development Mode... although this isn't a javadoc comment
Done. http://gwt-code-reviews.appspot.com/1221801/diff/1/54 File user/test/com/google/gwt/dev/jjs/scriptonly/ScriptOnlyTest.java (right): http://gwt-code-reviews.appspot.com/1221801/diff/1/54#newcode60 user/test/com/google/gwt/dev/jjs/scriptonly/ScriptOnlyTest.java:60: // Try something you can't do in web-mode (JRE code) On 2010/12/15 23:49:34, zundel wrote:
s/web-mode/Production Mode
Done. http://gwt-code-reviews.appspot.com/1221801/diff/1/54#newcode63 user/test/com/google/gwt/dev/jjs/scriptonly/ScriptOnlyTest.java:63: // Try something you can't do in web-mode ("server" code) On 2010/12/15 23:49:34, zundel wrote:
s/web-mode/Production Mode
Done. http://gwt-code-reviews.appspot.com/1221801/diff/1/59 File user/test/com/google/gwt/dev/jjs/test/JsStaticEvalTest.java (right): http://gwt-code-reviews.appspot.com/1221801/diff/1/59#newcode24 user/test/com/google/gwt/dev/jjs/test/JsStaticEvalTest.java:24: * Development Mode due to browser inconsistencies; however it should run in web On 2010/12/15 23:49:34, zundel wrote:
s/web/Production
Done. http://gwt-code-reviews.appspot.com/1221801/diff/1/61 File user/test/com/google/gwt/dom/client/StyleTest.java (right): http://gwt-code-reviews.appspot.com/1221801/diff/1/61#newcode110 user/test/com/google/gwt/dom/client/StyleTest.java:110: // TODO: re-enable these cases when we finally drop linux Development Mode. On 2010/12/15 23:49:34, zundel wrote:
Hey, we can probably re-enable these now!
I'll move this change to a separate patch http://gwt-code-reviews.appspot.com/1221801/diff/1/76 File user/test/com/google/gwt/xml/client/XMLTest.java (right): http://gwt-code-reviews.appspot.com/1221801/diff/1/76#newcode328 user/test/com/google/gwt/xml/client/XMLTest.java:328: */ On 2010/12/15 23:49:34, zundel wrote:
umm, maybe time to re-enable this test too?
I'll create a separate patch to re-enable this test http://gwt-code-reviews.appspot.com/1221801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
