http://gwt-code-reviews.appspot.com/1262802/diff/1/2 File dev/core/src/com/google/gwt/dev/util/Util.java (right):
http://gwt-code-reviews.appspot.com/1262802/diff/1/2#newcode982 dev/core/src/com/google/gwt/dev/util/Util.java:982: public static String[] split(String s, char separatorChar) { Have you benchmarked this versus String.split? A fair test would be to benchmark against a pre-compiled regex: static final Pattern SLASH_PATTERN = Pattern.compile('/'); String[] results = SLASH_PATTERN.split(input, 0); http://gwt-code-reviews.appspot.com/1262802/diff/1/2#newcode996 dev/core/src/com/google/gwt/dev/util/Util.java:996: list.add(StringInterner.get().intern(s.substring(start, i))); Factor out the call to StringInterner.get() http://gwt-code-reviews.appspot.com/1262802/diff/1/2#newcode1008 dev/core/src/com/google/gwt/dev/util/Util.java:1008: return list.toArray(new String[list.size()]); You could have a variant that returns List<String> and avoids this conversion, for callers that just need to iterate over the results and don't specifically require an array. http://gwt-code-reviews.appspot.com/1262802/diff/1/4 File dev/core/test/com/google/gwt/core/ext/util/UtilTest.java (right): http://gwt-code-reviews.appspot.com/1262802/diff/1/4#newcode116 dev/core/test/com/google/gwt/core/ext/util/UtilTest.java:116: "abc//def", Add a test for "abc///def" http://gwt-code-reviews.appspot.com/1262802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
