Agreed with the other comments, and a few more.

http://gwt-code-reviews.appspot.com/1262802/diff/1/5
File dev/core/src/com/google/gwt/dev/resource/impl/ZipFileResource.java
(right):

http://gwt-code-reviews.appspot.com/1262802/diff/1/5#newcode39
dev/core/src/com/google/gwt/dev/resource/impl/ZipFileResource.java:39:
this.pathParts = Util.split(path, '/');
It's pretty much guaranteed to get run eventually, so probably no harm.

http://gwt-code-reviews.appspot.com/1262802/diff/1/4
File dev/core/test/com/google/gwt/core/ext/util/UtilTest.java (right):

http://gwt-code-reviews.appspot.com/1262802/diff/1/4#newcode109
dev/core/test/com/google/gwt/core/ext/util/UtilTest.java:109: public
void testSplit() {
Needs alpha sort.

http://gwt-code-reviews.appspot.com/1262802/diff/1/4#newcode136
dev/core/test/com/google/gwt/core/ext/util/UtilTest.java:136:
assertTrue(equalsResult);
Also, can you check your computed outputs against String.split()?

http://gwt-code-reviews.appspot.com/1262802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to