Revision: 9508
Author: [email protected]
Date: Fri Jan 7 05:51:44 2011
Log: Rolling back r9505 due to CellViewSuite test breakages.
Review at http://gwt-code-reviews.appspot.com/1262801
Review by: [email protected]
http://code.google.com/p/google-web-toolkit/source/detail?r=9508
Modified:
/trunk/user/src/com/google/gwt/user/client/ui/SplitLayoutPanel.java
=======================================
--- /trunk/user/src/com/google/gwt/user/client/ui/SplitLayoutPanel.java Thu
Jan 6 12:11:16 2011
+++ /trunk/user/src/com/google/gwt/user/client/ui/SplitLayoutPanel.java Fri
Jan 7 05:51:44 2011
@@ -100,8 +100,6 @@
private final boolean reverse;
private int minSize;
- private double centerSize, syncedCenterSize;
-
public Splitter(Widget target, boolean reverse) {
this.target = target;
this.reverse = reverse;
@@ -178,36 +176,22 @@
protected abstract int getTargetSize();
- private double getMaxSize() {
- // To avoid seeing stale center size values due to deferred layout
- // updates, maintain our own copy up to date and resync when the
- // DockLayoutPanel value changes.
- double newCenterSize = getCenterSize();
- if (syncedCenterSize != newCenterSize) {
- syncedCenterSize = newCenterSize;
- centerSize = newCenterSize;
- }
-
- return ((LayoutData) target.getLayoutData()).size + centerSize;
- }
-
private void setAssociatedWidgetSize(double size) {
if (size < minSize) {
size = minSize;
}
-
- double maxSize = getMaxSize();
- if (size > maxSize) {
- size = maxSize;
- }
LayoutData layout = (LayoutData) target.getLayoutData();
if (size == layout.size) {
return;
}
- // Adjust our view until the deferred layout gets scheduled.
- centerSize += layout.size - size;
+ // Don't grow beyond remaining space
+ double centerSize = getCenterSize();
+ if (size - layout.size > centerSize) {
+ size = layout.size + centerSize;
+ }
+
layout.size = size;
// Defer actually updating the layout, so that if we receive many
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
