http://gwt-code-reviews.appspot.com/1264801/diff/1/2
File dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java (left):

http://gwt-code-reviews.appspot.com/1264801/diff/1/2#oldcode418
dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java:418: public
synchronized void refresh(TreeLogger logger) {
Remove TreeLogger as an arg? It causes a static analysis warning as is.

http://gwt-code-reviews.appspot.com/1264801/diff/1/2
File dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java (right):

http://gwt-code-reviews.appspot.com/1264801/diff/1/2#newcode324
dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java:324:
doRefresh(TreeLogger.NULL);
Looks like we are always passing TreeLogger.NULL. If so, why not just
remove the logging that no longer takes place?

http://gwt-code-reviews.appspot.com/1264801/diff/1/2#newcode492
dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java:492: needsRefresh =
true;
Consider calling refresh() instead.

http://gwt-code-reviews.appspot.com/1264801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to