http://gwt-code-reviews.appspot.com/1264801/diff/1/2 File dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java (left):
http://gwt-code-reviews.appspot.com/1264801/diff/1/2#oldcode418 dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java:418: public synchronized void refresh(TreeLogger logger) { On 2011/01/07 20:38:28, scottb wrote:
I wasn't sure if there were non-GWT callers on this public method.
Worth
fixing?
My understanding is that only com.google.gwt.core.ext.* is public API and anybody using anything else is depending upon implementation details. Unless we know it would cause egregious breakage, I think we should keep the codebase clean. http://gwt-code-reviews.appspot.com/1264801/diff/1/2 File dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java (right): http://gwt-code-reviews.appspot.com/1264801/diff/1/2#newcode324 dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java:324: doRefresh(TreeLogger.NULL); On 2011/01/07 20:38:28, scottb wrote:
Oops, already committed. Think it's worth another CL to clean this up?
Please. http://gwt-code-reviews.appspot.com/1264801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
