LGTM
http://gwt-code-reviews.appspot.com/1269801/diff/1/4 File plugins/xpcom/FFSessionHandler.h (left): http://gwt-code-reviews.appspot.com/1269801/diff/1/4#oldcode71 plugins/xpcom/FFSessionHandler.h:71: inline Debug::DebugStream& operator<<(Debug::DebugStream& dbg, JSString* str) { Why remove this? http://gwt-code-reviews.appspot.com/1269801/diff/1/5 File plugins/xpcom/JavaObject.cpp (right): http://gwt-code-reviews.appspot.com/1269801/diff/1/5#newcode115 plugins/xpcom/JavaObject.cpp:115: if (!JS_DefineFunction(ctx, obj, "toString", JavaObject::toString20, 0, 0)) { Since we don't ever need both definitions in one executable, would it be better to put the #ifdef around the definition of toString/call and just have the one version there? http://gwt-code-reviews.appspot.com/1269801/diff/1/7 File plugins/xpcom/Makefile (right): http://gwt-code-reviews.appspot.com/1269801/diff/1/7#newcode48 plugins/xpcom/Makefile:48: Extra blank line http://gwt-code-reviews.appspot.com/1269801/diff/1/12 File plugins/xpcom/install-template.rdf (right): http://gwt-code-reviews.appspot.com/1269801/diff/1/12#newcode14 plugins/xpcom/install-template.rdf:14: <!-- TODO: can we add 1.5-2.0 back? Do we care? --> I think we can remove this line now. http://gwt-code-reviews.appspot.com/1269801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
