LGTM

http://gwt-code-reviews.appspot.com/1269801/diff/1/5
File plugins/xpcom/JavaObject.cpp (right):

http://gwt-code-reviews.appspot.com/1269801/diff/1/5#newcode154
plugins/xpcom/JavaObject.cpp:154: if ((JS_GetStringEncodingLength(ctx,
str) == 8) && !strncmp("toString",
It might be worth doing like we did for JSIDs -- define
JS_GetStringEncodingLength(ctx,str) to be JS_GetStringLength(str) etc,
and that way we don't have to duplicate all this code, it just all uses
the new API.

http://gwt-code-reviews.appspot.com/1269801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to