http://gwt-code-reviews.appspot.com/1277801/diff/5001/6001
File plugins/npapi/NPVariantWrapper.h (right):

http://gwt-code-reviews.appspot.com/1277801/diff/5001/6001#newcode105
plugins/npapi/NPVariantWrapper.h:105: if (isInt(variant)) {
my concern with this is something I chatted with Jat a couple of weeks
ago. this will be called many times over and may affect perf.
could we consider using modf() that is presumably optimized and it would
be a one op to extract and check the integer part of a double.

http://gwt-code-reviews.appspot.com/1277801/diff/5001/6002
File plugins/npapi/main.cpp (right):

http://gwt-code-reviews.appspot.com/1277801/diff/5001/6002#newcode241
plugins/npapi/main.cpp:241: //Debug::log(Debug::Spam) <<
"NPP_HandleEvent(instance=" << instance << ")" << Debug::flush;
should this change be reverted?

http://gwt-code-reviews.appspot.com/1277801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to