http://gwt-code-reviews.appspot.com/1273801/diff/1/2 File user/src/com/google/gwt/user/client/rpc/CustomFieldSerializer.java (right):
http://gwt-code-reviews.appspot.com/1273801/diff/1/2#newcode19 user/src/com/google/gwt/user/client/rpc/CustomFieldSerializer.java:19: * An interface that may be implemented by class-based custom field serializers which will reduce On 2011/01/10 20:12:52, jat wrote:
> 80 chars, throughout the change
Done. http://gwt-code-reviews.appspot.com/1273801/diff/1/2#newcode37 user/src/com/google/gwt/user/client/rpc/CustomFieldSerializer.java:37: } On 2011/01/10 20:12:52, jat wrote:
Why only serialize? Shouldn't there be instantiateInstance and deserializeInstance methods as well?
This change was focused on improving serialization as that was the hot spot. For consistency, I have now added instantiateInstance and deserializeInstance. http://gwt-code-reviews.appspot.com/1273801/diff/1/3 File user/src/com/google/gwt/user/client/rpc/core/java/lang/Boolean_CustomFieldSerializer.java (right): http://gwt-code-reviews.appspot.com/1273801/diff/1/3#newcode44 user/src/com/google/gwt/user/client/rpc/core/java/lang/Boolean_CustomFieldSerializer.java:44: public void serializeInstance(final SerializationStreamWriter streamWriter, On 2011/01/10 20:12:52, jat wrote:
GWT style is to only use final on locals/parameters when it is
required, such as
for reference in an anonymous inner class.
Done. http://gwt-code-reviews.appspot.com/1273801/diff/1/6 File user/src/com/google/gwt/user/client/rpc/core/java/lang/Double_CustomFieldSerializer.java (right): http://gwt-code-reviews.appspot.com/1273801/diff/1/6#newcode45 user/src/com/google/gwt/user/client/rpc/core/java/lang/Double_CustomFieldSerializer.java:45: throws SerializationException { On 2011/01/10 20:12:52, jat wrote:
Continuation lines should be indented +4 columns. You might want to
look in
eclipse/README.txt to setup eclipse so formatting/etc matches our
style guide. I will do my best, but I use IntelliJ rather than eclipse. Is there a way of me testing the formatting by a command-line that understands the eclipse formatting? http://gwt-code-reviews.appspot.com/1273801/diff/1/33 File user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamWriter.java (right): http://gwt-code-reviews.appspot.com/1273801/diff/1/33#newcode288 user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamWriter.java:288: private static class CustomFieldSerializerHandle { On 2011/01/10 20:12:52, jat wrote:
What is the benefit of having this class over just storing a CustomFieldSerializer<?>, since it only holds a CFS instance and it
must be
initialized at creation?
This allows a single map lookup to determine if a class extends the CustomFieldSerializer class. If the map just had null values, there would have to be a following .contains() call. http://gwt-code-reviews.appspot.com/1273801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
