http://gwt-code-reviews.appspot.com/1273801/diff/1/6
File
user/src/com/google/gwt/user/client/rpc/core/java/lang/Double_CustomFieldSerializer.java
(right):
http://gwt-code-reviews.appspot.com/1273801/diff/1/6#newcode45
user/src/com/google/gwt/user/client/rpc/core/java/lang/Double_CustomFieldSerializer.java:45:
throws SerializationException {
On 2011/01/17 02:05:46, Miles Chaston wrote:
On 2011/01/10 20:12:52, jat wrote:
> Continuation lines should be indented +4 columns. You might want to
look in
> eclipse/README.txt to setup eclipse so formatting/etc matches our
style guide.
I will do my best, but I use IntelliJ rather than eclipse.
Is there a way of me testing the formatting by a command-line that
understands
the eclipse formatting?
Will do.
http://gwt-code-reviews.appspot.com/1273801/diff/1/33
File
user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamWriter.java
(right):
http://gwt-code-reviews.appspot.com/1273801/diff/1/33#newcode288
user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamWriter.java:288:
private static class CustomFieldSerializerHandle {
On 2011/01/18 19:34:29, jat wrote:
An alternative to wrapping everything would be to have a single value,
like you
do for EMPTY_HANDLE, to indicate that it is known not to extend
CustomFieldSerializer. It could just be a private implementation of
CustomFieldSerializer that does nothing and is compared against.
That would keep single lookups in the map, while also avoiding wrapper
objects.
Good idea. I will do that.
http://gwt-code-reviews.appspot.com/1273801/diff/8001/9034#newcode728
user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamWriter.java:728:
continue;
On 2011/01/18 19:34:29, jat wrote:
Won't this give a raw type warning? If so, it should be
CustomFieldSerializer<?> instead.
Good catch. My IDE was not calling that out. I tried with <?> and then
the serializeInstance got upset as the second parameter is expecting <?>
but was Object.
I have done what I can. Every time that I tried to make it explicit, I
caused issues somewhere else. I reverted to forcing to
CustomFieldSerializer<Object> and making the call
@SuppressWarnings("unchecked"). If you have any better ideas I would be
happy to try them.
http://gwt-code-reviews.appspot.com/1273801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
