http://gwt-code-reviews.appspot.com/1149803/diff/22001/23001 File user/src/com/google/gwt/user/client/ui/DialogBox.java (right):
http://gwt-code-reviews.appspot.com/1149803/diff/22001/23001#newcode113 user/src/com/google/gwt/user/client/ui/DialogBox.java:113: public interface Caption extends HasAllMouseHandlers, HasHTML, IsWidget { On the other hand, UiBinder knows how to parse things that implement HasHtml, but it doesn't have a clue yet about HasSafeHtml. I don't think this is good advice until HasHtml is deprecated, which we haven't managed to do quite yet. On 2011/01/18 15:59:56, jlabanca wrote:
Replace HasHTML with HasSafeHtml. We're moving away from String html
methods. http://gwt-code-reviews.appspot.com/1149803/diff/22001/23001#newcode372 user/src/com/google/gwt/user/client/ui/DialogBox.java:372: caption.setHTML(html); If this makes sense here, shouldn't we be doing it in every setHTML(String) method? Doing it some places and not others seems pretty confusing. On 2011/01/18 15:59:56, jlabanca wrote:
caption.setHTML(SafeHtmlUtils.fromTrustedString(html))
http://gwt-code-reviews.appspot.com/1149803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
