http://gwt-code-reviews.appspot.com/1149803/diff/1/3
File user/src/com/google/gwt/user/client/ui/DialogBox.java (right):
http://gwt-code-reviews.appspot.com/1149803/diff/1/3#newcode116
user/src/com/google/gwt/user/client/ui/DialogBox.java:116: * your own
risk.
On 2011/01/04 18:41:53, rjrjr wrote:
Now that it's actually useful to implement the interface, I don't
think we can
keep this disclaimer.
Done.
http://gwt-code-reviews.appspot.com/1149803/diff/1/3#newcode320
user/src/com/google/gwt/user/client/ui/DialogBox.java:320: public void
setCaption(Caption caption) {
On 2011/01/04 18:41:53, rjrjr wrote:
Your removal code here looks wrong, and I don't think it's worth
making it
right. Instead make the caption an optional constructor argument, not
a settable
property.
Anyone who wants that kind of flexibility and its headaches can
provide a
caption that extends Panel or something.
I figured that allowing the setting of the header would make it cleaner
to add a custom header via ui:binder. That being said it isn't the
prettiest of code. I've changed this to your suggestion and made it
immutable via the constructor
http://gwt-code-reviews.appspot.com/1149803/diff/1/3#newcode338
user/src/com/google/gwt/user/client/ui/DialogBox.java:338:
caption.asWidget().setStyleName("Caption");
On 2011/01/04 18:41:53, rjrjr wrote:
If we're accepting someone else's widget, it seems wrong to clobber
their style
name.
Good catch. Done.
http://gwt-code-reviews.appspot.com/1149803/diff/1/3#newcode343
user/src/com/google/gwt/user/client/ui/DialogBox.java:343: * Sets the
html string inside the caption.
On 2011/01/04 18:41:53, rjrjr wrote:
" by calling its {@link #setHTML(SafeHTML)} method."
Done.
http://gwt-code-reviews.appspot.com/1149803/diff/1/3#newcode355
user/src/com/google/gwt/user/client/ui/DialogBox.java:355: * Sets the
html string inside the caption.
On 2011/01/04 18:41:53, rjrjr wrote:
" by calling its {@link #setHTML(String)} method."
Done.
http://gwt-code-reviews.appspot.com/1149803/diff/1/3#newcode367
user/src/com/google/gwt/user/client/ui/DialogBox.java:367: * Sets the
text inside the caption.
On 2011/01/04 18:41:53, rjrjr wrote:
" by calling its {@link #setText(SafeHTML)} method."
Done.
http://gwt-code-reviews.appspot.com/1149803/diff/1/3#newcode486
user/src/com/google/gwt/user/client/ui/DialogBox.java:486: protected
void registerMouseHandlers() {
On 2011/01/04 18:41:53, rjrjr wrote:
won't need this with immutable caption
Done.
http://gwt-code-reviews.appspot.com/1149803/diff/1/2
File user/test/com/google/gwt/user/client/ui/DialogBoxTest.java (right):
http://gwt-code-reviews.appspot.com/1149803/diff/1/2#newcode158
user/test/com/google/gwt/user/client/ui/DialogBoxTest.java:158: // TODO
Auto-generated method stub
On 2011/01/04 18:41:53, rjrjr wrote:
snip
done
http://gwt-code-reviews.appspot.com/1149803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
